Add JAVA_OPTS and JAVA_TOOL_OPTIONS to envoverwriter #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edeNFed
approved these changes
May 24, 2024
blumamir
approved these changes
May 26, 2024
| @@ -210,6 +211,11 @@ func getWorkloadRolloutJsonPatch(obj client.Object, pts *v1.PodTemplateSpec) ([] | |||
|
|
|||
| // remove odigos instrumentation device from containers | |||
| for iContainer, c := range pts.Spec.Containers { | |||
| _, sdk, found := odgiosK8s.GetLanguageAndOtelSdk(c) | |||
There was a problem hiding this comment.
The for loop below is already executed in the GetLanguageAndOtelSdk function. Does it make sense to also return the device name from the util function?
| return false | ||
| } | ||
|
|
||
| if !strings.Contains(value, val) { |
blumamir
reviewed
May 26, 2024
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1130