Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix german grammar #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix german grammar #24

wants to merge 3 commits into from

Conversation

ndim
Copy link

@ndim ndim commented Jan 19, 2016

This fixes the German grammar in the documentation and tests.

In the target conflict between using properly nice German and keeping it understandable for someone who does not understand any German, we err on the side of keeping the text understandable for people not understanding German.

We are only fixing the grammar here.

Proper German capitalization of the title is left for another time,
as this might require changes not only to strings, but also to config
or even code.
Express the meaning of the phrase in grammatically correct German.
Fix German grammar in README.md as far as it does not
inhibit understanding the examples by people without
a working knowledge of German.

For that reason, we refrain from translating "title"
to "Überschrift", as "Titel" is good enough German
for this purpose and still understandable for someone
understanding English, but without a working knowledge
of German.
@ndim
Copy link
Author

ndim commented Jan 19, 2016

Please note that the Travis CI check fails with

[…]/octopress/multilingual/lib/octopress-multilingual/jekyll.rb:85:in `<class:Post>': undefined method `template' for class `Jekyll::Post' (NameError)

which is not related to this pull request, but to octopress-multilingual's reliance on Jekyll::Post (which has been removed in jekyll 3.0.0).

Adding a requirement to octopress-multilingual's Gemfile would fix this issue:

gem 'jekyll', '< 3.0.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant