Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding multilingual processing for Pages; mimicking process used for … #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uaqben
Copy link

@uaqben uaqben commented Aug 10, 2015

Hi @imathis

This is my first pull request - I hope it's ok 😅

I looked into the gem's code to see if I could solve my problem #19 "upstream".

Basically I duplicated parts of the processing I saw you were doing for Posts, and set these to focus on Pages.

The result is that it solves my issue #19

I can use the super-clean markup for my navigation bar in the _includes/header, (ie. just using the default[1]), and now compiling the site jekyll will correctly only pull/include the pages which are of the same language.

If you can include and/or improve this multilingual processing for Pages it would be really cool. Thanks!

[1] {% for page in site.pages %} {% if page.title %} ... {% endif %} {% endfor %}

@uaqben uaqben mentioned this pull request Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant