Improve implementation of deepFindPathToProperty function #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58
Before the change?
The
deepFindPathToProperty
function would occasionally fail withTypeError: Cannot read properties of null (reading 'hasOwnProperty')
.After the change?
The error has been fixed:
src/object-helpers.ts
: ThedeepFindPathToProperty
function was refactored and its return type updated fromstring[]
tostring[] | null
. The refactoring includes the introduction of a new typeTreeNode
and several new helper functions likegetDirectPropertyPath
,makeTreeNodeChildrenFromData
, andfindPathToObjectContainingProperty
. ThefindPaginatedResourcePath
function was also updated to accommodate these changes.test/typescript-validate.ts
: ThepageInfoBackwaredExported
function was renamed topageInfoBackwardExported
for correct spelling.test/object-helpers.test.ts
: New tests were added for thefindPaginatedResourcePath
function to validate its behavior in different scenarios.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!