build: attempts to fix the issue with the release action by updating to a version of octokit/core with an entry point #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion of octokit/core with an entry point
nickfloyd
added
Type: Maintenance
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
gr2m
changed the title
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change?
I noticed a couple of weeks ago when we updated @octokit/core in octokit/openapi semantic release started failing. I am guessing this has to do with the ESM cutover - I'm currently trying to determine if semantic release supports ESM based modules.
If it's a missing entry point, there was a later PR to add an entry point to octokit/core (v6.0.1) - I figured the ^ notation in octokit/openapi’s package.json (“@octokit/core”: “^6.0.0") for core would’ve picked up this minor bump. While I feel like I might be missing something obvious I went ahead and updated all of the dev dependencies as a sanity check to see if that would unblock us.
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!