Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Removes PubSubHubbub module and /hub API endpoint implementation #1675

Merged
merged 2 commits into from Mar 25, 2024

Conversation

mjimenez98
Copy link
Contributor

Part of https://github.com/github/ecosystem-events/issues/3517


Before the change?

After the change?

  • Remove PubSubHubbub module. Webhooks API is accessible through the Hooks module, which uses the endpoints documented in GitHub's public docs

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Mar 25, 2024
@nickfloyd nickfloyd changed the title Remove PubSubHubbub module BREAKING CHANGE: Removes PubSubHubbub module and /hub API endpoint implementation Mar 25, 2024
@nickfloyd
Copy link
Contributor

Thanks for the contributions here @mjimenez98 ❤️

@nickfloyd nickfloyd merged commit f93820d into octokit:main Mar 25, 2024
14 checks passed
@mjimenez98 mjimenez98 deleted the mj98-ock-rps branch March 25, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants