Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use auto pagination when retrieving environments #1673

Merged
merged 1 commit into from Mar 11, 2024

Conversation

pedrocarrico
Copy link
Contributor

Before the change?

  • Listing environments would only fetch the first page if auto_paginate is set to true.

After the change?

  • Listing environments will fetch all the pages if auto_paginate is set to true.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No

Copy link

github-actions bot commented Mar 7, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Mar 11, 2024
@nickfloyd nickfloyd changed the title Use auto pagination when retrieving environments bug: Use auto pagination when retrieving environments Mar 11, 2024
@nickfloyd nickfloyd changed the title bug: Use auto pagination when retrieving environments fix: Use auto pagination when retrieving environments Mar 11, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedrocarrico good catch & thanks for the contributions here! ❤️

@nickfloyd nickfloyd merged commit d2e6197 into octokit:main Mar 11, 2024
12 checks passed
@pedrocarrico
Copy link
Contributor Author

My pleasure @nickfloyd , keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants