Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Allow Nulls to be Passed to BranchProtectionRequiredReviewsDismissalRestrictionsUpdate Constructor #2850

Open
1 task done
WesBossPro opened this issue Jan 9, 2024 · 0 comments
Open
1 task done

[FEAT]: Allow Nulls to be Passed to BranchProtectionRequiredReviewsDismissalRestrictionsUpdate Constructor #2850

WesBossPro opened this issue Jan 9, 2024 · 0 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@WesBossPro
Copy link

Describe the need

Is there a reason BranchProtectionTeamCollection teams and BranchProtectionUserCollection users are not nullable?

Because I noticed when a bool is passed as false to the BranchProtectionRequiredReviewsDismissalRestrictionsUpdate constructor both BranchProtectionTeamCollection teams and BranchProtectionUserCollection users are simple set to null.

Wouldn't it just be easier to allow those properties to be nullable?

image

SDK Version

Octokit.net v9.1.0

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@WesBossPro WesBossPro added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 9, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jan 18, 2024
@WesBossPro WesBossPro changed the title [FEAT]: Allow Nulls for To Be Passed to BranchProtectionRequiredReviewsDismissalRestrictionsUpdate Constructor [FEAT]: Allow Nulls to be Passed to BranchProtectionRequiredReviewsDismissalRestrictionsUpdate Constructor Jan 19, 2024
@wesdevpro wesdevpro mentioned this issue May 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
🧰 Octokit Active
Status: 🔥 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfcampbell @WesBossPro