Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable #2900

Open
1 task done
wesdevpro opened this issue Apr 5, 2024 · 1 comment
Open
1 task done

[BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable #2900

wesdevpro opened this issue Apr 5, 2024 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@wesdevpro
Copy link
Contributor

What happened?

image
According to the official docs these fields can be null (this wont set the property in the UI on GitHub) However, Octokit.net does not allow for these properties to at least default to null but an empty list (this sets the property in the UI on GitHub).

Should/Can this be changed to allow developers to use the API to it's fullest extent?

Versions

Octokit.net

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wesdevpro wesdevpro added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Apr 5, 2024
@wesdevpro wesdevpro changed the title [BUG/FEAT]: BranchProtetionPushRestictions Should Be Nullable [BUG/FEAT]: BranchProtetionPushRestictions Properties Should Be Nullable Apr 5, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Apr 15, 2024
@wesdevpro
Copy link
Contributor Author

wesdevpro commented May 1, 2024 •
edited

@nickfloyd @kfcampbell I attempted to implement this feature but I get build issues that seem to be related to #2865. Is this possible? Also if so then I believe #2850 would also be affected from the same issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Status: 🔥 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfcampbell @wesdevpro