New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Initial design of the rate limit handler #51
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
…e rate limit handler to encapsulate the error and return a meaningful message on primary failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot approve a PR that I am author on but I 100% ✅ this. Can't wait for it to land! Your test coverage is 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick can't approve this PR since he initially proposed it, so I'm doing it instead!
This PR adds rate-limiting awareness (of both primary and secondary rate limits) to the dotnet-sdk. It has been validated against local versions of github/github. Note that it does not change any abstractions used to access the SDK client as octokit/go-sdk#52 did. Coverlet gives unit testing coverage of 98% of lines and 83% of branches.
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!