Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade NuGet package versions to resolve Native AOT warnings. #49

Merged
merged 2 commits into from Mar 7, 2024
Merged

Upgrade NuGet package versions to resolve Native AOT warnings. #49

merged 2 commits into from Mar 7, 2024

Conversation

IEvangelist
Copy link
Contributor

  • Upgrade NuGet package versions to resolve Native AOT warnings.
  • Update copyright dates.
  • Remove strategy: fail-fast: false as the workflow isn't a matrix.
  • Update to actions/checkout@v3.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd
nickfloyd approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @IEvangelist, as always, thank you for the efforts here ❤️

.editorconfig Outdated Show resolved Hide resolved
src/GitHub.Octokit.SDK.csproj Show resolved Hide resolved
@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Mar 7, 2024
kfcampbell
kfcampbell approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@nickfloyd
Copy link
Contributor

@IEvangelist Those merge conflicts are on me. I'd be glad to clean them up if you cannot get to them. Apologies for the disruption there.

@IEvangelist
Copy link
Contributor Author

@IEvangelist Those merge conflicts are on me. I'd be glad to clean them up if you cannot get to them. Apologies for the disruption there.

@nickfloyd - No worries, I resolved them - thank you

@nickfloyd nickfloyd merged commit 16cbc59 into octokit:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IEvangelist @nickfloyd @kfcampbell