WIP: Sameness #1410
Draft
WIP: Sameness #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change revealed some issues with some js stubs what were returning |
TyOverby
approved these changes
Feb 22, 2023
|
@ty, is there any per difference between the two ? Is |
|
https://caniuse.com/mdn-javascript_builtins_object_is It’s pretty widely supported! |
|
As for performance impacts, I don't have a good intuition for if it would be faster or slower. A small microbenchmark that I just made seems to indicate that
|
|
some other seems to show that |
hhugo
force-pushed
the
sameness
branch
2 times, most recently
from
eb52732
to
dc2ff61
Compare
|
I'm not really happy with the current implementation, mostly because the decision to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1372