use eager-input-filter optimize TopN #1501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
woxiaosa
force-pushed
the
issue_1500
branch
3 times, most recently
from
8933052
to
9e4bba1
Compare
woxiaosa
force-pushed
the
issue_1500
branch
2 times, most recently
from
8997937
to
1bcea63
Compare
stdliu
suggested changes
Aug 24, 2023
| LOG_DEBUG("is not initialized", K(ret)); | ||
| } else if ((seq_no + 1) % per_bucket_num_ == 0) { | ||
| if (heap_->count() < bucket_num_) { | ||
| if (use_heap_sort && OB_FAIL(generate_new_row(static_cast<SortStoredRow *>(dump_row), |
There was a problem hiding this comment.
Always copy from StoredRow here, decoupling with the outside heap sort logic.
stdliu
suggested changes
Aug 24, 2023
woxiaosa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
close #1500
use eager-input-filter to optimize TopN.
this optimization can reduce the amount of dumped data in TopN
Solution Description
I created a class
EagerInputFilterto collect statistics of dumped data, thereby reducing the amount of dumped.Passed Regressions
pass tests in ob repo
Upgrade Compatibility
This optimization is orthogonal to the implementation of Sort, so it's easy to integrate this optimization.
Release Note
In TopN with a large amount of data, this optimization can speed up 1.3-1.6X.