fixed #1432: complete the notify_ function #1455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 7, 2023
wxhwang
reviewed
Jul 11, 2023
wxhwang
reviewed
Jul 11, 2023
wxhwang
reviewed
Jul 11, 2023
wxhwang
reviewed
Jul 11, 2023
xuhuleon
reviewed
Jul 11, 2023
xuhuleon
suggested changes
Jul 11, 2023
xuhuleon
suggested changes
Jul 11, 2023
fjygf
force-pushed
the
issue_1432
branch
2 times, most recently
from
780e95a
to
e9e9de7
Compare
wxhwang
reviewed
Jul 14, 2023
wxhwang
reviewed
Jul 14, 2023
xuhuleon
approved these changes
Jul 14, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
close #1432
When the user executes the start/defer/stop archive command, it simply changes the archive status.
The background task ObArchiveService needs to query the archive status periodically to actually start/defer/stop archive.
There is room for optimizing the time to start/defer/stop archive.
Solution Description
When in BEGINNING state, notify each log stream event of archive start.
When in SUSPENDING state, notify each log stream event of archive defer.
When in STOPPING state, notify each log stream event of archive stop.
1-Get all log stream leaders of the current tenant.
2-Wake up ObArchiveService via obrpc.
Passed Regressions
N/A
Upgrade Compatibility
N/A
Other Information
N/A
Release Note
N/A