Tweaks to internal Cygwin setup #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, sorting out the work for |
Enhances what's available in the bin directory
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5793, this adds
--symlink-type nativeto the Cygwin setup invocation if the user has the ability to create them. This is more to disable the use of WSL symlinks than to actually enable any additional binaries (Cygwin names binaries.exe, but it doesn't do that for a symlink to an executable, so they're not any more available than they were before).We can save a small amount of time and a potential error message by passing
--no-version-check- that simply tells Cygwin not to report if the version of setup is older than the latest reported insetup.ini.Hot off the presses in Setup 2.929 is an option to reduce the noise of the installation. We should definitely use the
noinputversion at all times, but thehiddenversion is nice as it suppresses the GUI completely. The caveat, and why I'm keeping this as draft for now, is that there is no UI for Cygwin at all, then, so we need to display some kind of "Please wait..." indicator and possibly spinner ourselves.