-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic tracing #5757
base: master
Are you sure you want to change the base?
basic tracing #5757
Conversation
Thanks a lot for this! I have a couple of questions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on first glance
We’re trying to get 2.2.0 out the door asap and i’d prefer to merge this after the release to avoid unnecessary time spent in extra maintenance and CI work (don’t worry the CI failure is unrelated to you changes). |
Of course, no worries! This is really a tool to debug/improve opam itself, not something end users urgently need, I think. |
this cuts the time spent on parsing `pacman -Si` significantly down
6ed05e0
to
c7b6f5e
Compare
This is WIP.
I'm adding tracing to find why opam is so slow on my machine. It gives excellent insights on where time is spent (e.g after
opam upd
, all 30k files are read one by one, to update the cache).I've been instrumenting things as I explore but it needs to be more principled in general I think.
The overhead when tracing is not active (ie
TRACE_FILE
is not set) should be fairly low.