Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release not-ocamlfind 0.13 #25794

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

chetmurthy
Copy link
Contributor

add "-impl", "-intf" to "preprocess" command (pass thru to camlp5).
Also fix Freebsd build process.

@chetmurthy
Copy link
Contributor Author

OK, there are three sorts of errors:

  1. macos-homebrew: not-ocamlfind depends on "conf-m4" and that doesn't seem to be building on this platform.

  2. freebsd: freebsd's diff seems to behave differently from GNU diff, and is throwing errors during a camlp5 test.

  3. frama-clang is failing to build on Debian. I checked doing the following:

a. take a failing testcase
b. run the Docker script (uses Debian, OCaml 4.14) on my Ubuntu machine: it fails.
c. remove my PR from the script, so its just based on master: it still fails in the same way.
d. then swap out the Debian image for an Ubuntu image: it WORKS.

So I conjecture that there's a problem with frama-clang on Debian.

So it seems none of these test-failures have anything to do with this PR.

@raphael-proust
Copy link
Collaborator

  1. freebsd: freebsd's diff seems to behave differently from GNU diff, and is throwing errors during a camlp5 test.

IIRC, you can use gdiff when on freebsd. But it's cumbersome to have to check what system you are in and all…

I'm tempted to say that we can merge regardless. But we could also add

x-ci-accept-failures: ["freebsd"]

freebsd diff is different from gdiff
@chetmurthy
Copy link
Contributor Author

Good idea, I'll do that. Also, in more-recent versions I do check for freebsd and use a different diff; since the failures are with older versions, I'll just skip it.

@chetmurthy
Copy link
Contributor Author

alright, looks like

  1. still conf-m4 failures on macos-homebrew
  2. frama-clang "ld" failures (I didn't look into them, b/c they're appearing in the same places as they did the previous time)

@mseri mseri merged commit c1bf247 into ocaml:master May 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants