Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ sqlgg 20231201 #24884

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

+ sqlgg 20231201 #24884

wants to merge 6 commits into from

Conversation

ygrek
Copy link
Contributor

@ygrek ygrek commented Dec 1, 2023

No description provided.

Copy link
Collaborator

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you look into the lower bound check failures like the following?

packages/sqlgg/sqlgg.20231201/opam Outdated Show resolved Hide resolved
"ocaml" {>= "4.03.0"}
"dune" {>= "2.0"}
"menhir"
"mybuild"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that mybuild does not like the following distros and are failing the CI jobs.
But those are not directly related to this PR and I think we can safely ignore them.

  • arm32-ocaml-5.1
  • ocaml-5.1-afl
  • ppc64-ocaml-5.1
  • x86_32-ocaml-5.1

Co-authored-by: Haochen M. Kotoi-Xie <hx@kxc.inc>
@mseri
Copy link
Member

mseri commented Dec 18, 2023

@ygrek can you make the fixes also upstream?
There is a failure that I still don't understand in https://github.com/ygrek/sqlgg/blob/master/src/gen_caml.ml#L430

# File "src/gen_caml.ml", line 438, characters 6-10:
# 438 |     | None -> exec
#             ^^^^
# Error: This pattern should not be a constructor, the expected type is
#        Sqlgg.Sql.param_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants