-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf-gmp: use pkg-config where available #23330
base: master
Are you sure you want to change the base?
Conversation
See ocaml#18129 and ocaml#22954 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Checked packages:
Upper bound needed for mlgmp, numerix although they were already broken in systems with non-standard include paths |
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Hi @mseri |
I need to check all the packages in the comment above, ensure that they link properly and that their reverse dependencies all still work. Once they all have a checkmark, we can undraft this |
There is a PR in zarith to use pkg-config for gmp, which will also align it to this PR |
Any chance this could be revived? gmp and zarith cannot be installed on osx with custom Homebrew paths at the moment. |
There's been progress on the |
I will try to take some time to continue, but this is completely manual work and takes a lot of time for each package. I am not sure when I can unblock it. |
the change to make zarith use pkg-config has been merged in the meantime (ocaml/Zarith#132) and published in zarith 1.13 (release-1.13) |
See #18129 and #22954
I need to test the dependencies in
opam list --depends-on conf-gmp
before un-drafting