Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new file: packages/odnnr/odnnr.2.0.3/opam #23309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@UnixJunkie UnixJunkie mentioned this pull request Feb 14, 2023
install.packages('keras', repos='http://cran.r-project.org')
library(keras)""" {failure}
extra-files: [
["install_keras.r" "md5=ad1bb71c78db06e7a38b24ec6b34273d"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing

# here, we just test that the keras library can be loaded in R
pkg <- 'keras'
if (!require(pkg, character.only = TRUE)) {
install.packages(pkg, dependencies = TRUE, repos='http://cran.r-project.org')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this pattern is everywhere in your R-related packages, and I’ve kinda let that slip under the rug for all those years but how is this supposed to work without network access? (sandbox)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No: no network access implies you cannot install these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the sandbox too tight, if we cannot download listed things at install time?
Of course, R will also download all the required dependencies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants