Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding file for larex preamble file #774

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NiraliJoshi17
Copy link

Adding a preamble file as a support-files.tex and define a rule for this in dune file.

Adding new preamble file
Adding a rule for preamble file in dune file.
@jonludlam
Copy link
Member

Hi @NiraliJoshi17, thanks for this! It's looking good so far, you've added the latex file as an OCaml module. The next steps are to install it as part of the support-files CLI sub command, as suggested in issue #588

Also you'll need to reformat the dune file as it's causing the CI to fail. To do this, install ocamlformat.0.19.0 and run

dune build @fmt 
dune promote

and commit the results.

@EmileTrotignon
Copy link
Collaborator

EmileTrotignon commented Dec 5, 2023

Is this still relevant ?
If yes it should be reasonably easy to rebase and merge, so I am including it in the 2.4 milestone for now.
@NiraliJoshi17

@EmileTrotignon EmileTrotignon added this to the 2.4.0 milestone Dec 5, 2023
@jonludlam
Copy link
Member

The feature is still needed, but the implementation would be different today (crunch), and some futher work is required for proper integration.

}{}
\newcommand{\inputchapter}[1]{\chapter{#1}
\input{#1}}
\begin{document}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That part seems dubious. The preamble shouldn't be a document.

@Julow Julow removed this from the 2.4.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants