Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdint and zmq packages #33

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

stdint and zmq packages #33

wants to merge 13 commits into from

Conversation

mryau
Copy link

@mryau mryau commented May 26, 2017

No description provided.

build-doc: [ "ocaml" "setup.ml" "-doc" ]
depends: [
"ocaml-android"
"base-bytes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

depends: [
"ocaml-android"
"base-bytes"
"ocamlfind" {>= "1.5"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

@@ -0,0 +1 @@
zmq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as opam does not know about -toolchain

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

without such findlib files for zmq-android and stdint, ocamlfind can't find this packages when I compile my code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't make any sense, ocamlfind does not use these "findlib" files. Are you sure there was no other difference? Can you check one more time please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no findlib files in opam-repository anymore. ocaml/opam-repository#9328

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I remove them too -- on clear installation I don't seen problems without findlib files.

@@ -0,0 +1 @@
stdint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as opam does not know about -toolchain

depends: [
"ocaml-android"
"conf-zmq-android"
"ocamlfind"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

"ocaml-android"
"conf-zmq-android"
"ocamlfind"
"base-unix"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

"ocamlbuild" {build}
]
conflicts: [
"ocaml-zmq"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason for this conflict

Copy link
Author

@mryau mryau May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm steal this opam file from author of package, and just modified related part's. This line written by author of zmq.

@@ -0,0 +1,3 @@
Virtual package relying on zmq library installation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use virtual packages for native dependencies in cross-toolchains

]
depends: [
"ocaml-android"
"conf-zmq-android"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this dependency, you should add a depext for the zmq package in MXE

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MXE means http://mxe.cc/ ?
I don't use android-ndk -- I'm sit on yocto/bitbake with plain gcc cross-compiler suite, so I can't use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, MXE is not relevant, forget this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants