Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate with inventory #3049

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Simulate with inventory #3049

wants to merge 2 commits into from

Conversation

megies
Copy link
Member

@megies megies commented Apr 19, 2022

What does this PR do?

Makes it possible to use Inventory/Response objects as input in Stream/Trace.simulate() and obspy.signal.invsim.simulate_seismometer.

Why was it initiated? Any relevant Issues?

These routines are very old, from before these new objects and when mostly poles and zeros dictionaries and the like were used to describe instrument responses.

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the "build_docs" tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the "test_network" tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • Add the "ready for review" tag when you are ready for the PR to be reviewed.

to specify the original instrument for deconvolution part
and use pre_filt instead for stabilizing deconvolution
@megies megies added the .signal issues related to our signal processing functionalities label Apr 19, 2022
@megies megies added this to the 1.4.0 milestone Apr 19, 2022
@megies
Copy link
Member Author

megies commented Apr 19, 2022

Still needs tests, and Trace and simulate_seismometer() could also be made to accept Response objects for the simulation part

@megies megies marked this pull request as draft April 19, 2022 09:40
@megies
Copy link
Member Author

megies commented Apr 20, 2022

CC @igmuhlmann regarding your gitter post

@megies
Copy link
Member Author

megies commented Nov 15, 2022

Bumping this to 1.5.0

@megies megies modified the milestones: 1.4.0, 1.5.0 Nov 15, 2022
@obspy-bot
Copy link
Contributor

This pull request has been mentioned on ObsPy Forum. There might be relevant details there:

https://discourse.obspy.org/t/simulating-instrument-response/1624/2

@megies megies modified the milestones: 1.5.0, 1.6.0 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.signal issues related to our signal processing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants