Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all headers to io.kinemetrics (12 channel version) #2934

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ThomasLecocq
Copy link
Contributor

What does this PR do?

Reads and processes ALL header parameters from EVT files

Why was it initiated? Any relevant Issues?

A quest to be exhaustive (and a question from an user)

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .

TODO:

  • check the translation of a few bits to "real value"
  • add tests (get an external code to output the header values from the test files)
  • add info to the documentation

IDEALLY:

  • restructure the header reading part, but that's not essential

@ThomasLecocq ThomasLecocq self-assigned this Jan 6, 2022
@ThomasLecocq
Copy link
Contributor Author

🔴 do not merge, I have to revert the passing of apply_calib #2935

@megies megies marked this pull request as draft April 13, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants