-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libobs: Mix audio of each source in a scene only once #10537
Conversation
daadc4c
to
72de1f3
Compare
f41c758
to
0caa64d
Compare
0caa64d
to
cc6df7e
Compare
This solves duplicated scene items causing multiplied audio and LGTM. Outside of this PR, we still need to solve scene items inside nested scenes causing the same issue. |
cc6df7e
to
bdefd4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had concerns about half fixing this issue if nested scenes and groups still exhibited this issue. Rodney has now updated this PR to handle sources nested inside subscenes or groups.
The only edge case not handled now is Show/Hide transitions on the Subscene or Group itself.
Fixing that would require a much larger overhaul of the audio subsystem and I believe it is uncommon enough to be acceptable.
bdefd4f
to
9a59e3b
Compare
9a59e3b
to
63b73a1
Compare
Description
Only mix audio of each unique source in a scene once.
Motivation and Context
Fixes a common pitfall as the constructive interference due to multiple scene items using the same source is not visible anywhere.
Based on discussions this should not happen.
How Has This Been Tested?
Pure sine wave media source and ffmpeg
volumedetect
to make sure recordings after this fix have the same volume as a recording with only one scene item.Types of changes
Checklist: