Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Volume signal cleanup #10238

Merged
merged 2 commits into from
May 12, 2024
Merged

UI: Volume signal cleanup #10238

merged 2 commits into from
May 12, 2024

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Feb 13, 2024 •
edited

Description

Commit 1 - Use vector for volume signals
Commit 2 - Use OBSSourceLabel for volume controls

Motivation and Context

Cleaner code

How Has This Been Tested?

Used volume controls and renamed sources

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added the Code Cleanup Non-breaking change which makes code smaller or more readable label Feb 13, 2024
@Lain-B Lain-B self-assigned this Mar 31, 2024
@tt2468 tt2468 self-assigned this May 11, 2024
@cg2121
Copy link
Contributor Author

cg2121 commented May 12, 2024

Updated to latest master

@cg2121
UI: Use vector for volume control signals
3603fb5 
This cleans up the volume control code by using a vector for
signals.
@cg2121
UI: Use OBSSourceLabel for VolControl
c847421 
The OBSSourceLabel handles renaming of a source, so we don't have
to use the rename signals for volume controls.
@cg2121
Copy link
Contributor Author

cg2121 commented May 12, 2024

Updated to fix merge conflict

@tt2468 tt2468 merged commit b82a49e into obsproject:master May 12, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 12, 2024
@cg2121 cg2121 deleted the vol-sigs branch May 12, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt2468 tt2468 tt2468 approved these changes

Assignees

@tt2468 tt2468

@Lain-B Lain-B

Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Milestone
OBS Studio 30.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cg2121 @tt2468 @RytoEX @Lain-B