Add option to use static runtime #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computerquip-streamlabs
force-pushed
the
optional-crt
branch
from
5a1f8f4
to
8e2edb5
Compare
computerquip-streamlabs
force-pushed
the
optional-crt
branch
from
8e2edb5
to
3ed2804
Compare
WizardCM
added
Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to have been misconception of not being able to use /MD when using libcef. This isn't true due to the use of the libcef_dll_wrapper described here.
This adds an option to dynamically link against the runtime by setting BROWSER_USE_STATIC_CRT to a falsey value.
While I've set the default value here to true, I don't suggest statically against the runtime here at all. I've set it to default only because this is how it was already set and it felt less intrusive.