Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaterialIcons variants #1596

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

viniciusyoshioka
Copy link

Hello!

This PR adds the variants outlined, round and sharp to MaterialIcon. Those variants can be used by passing its name as a prop to the icon component (as @johnf said in this comment), e.g.:

<MaterialIcon
    name={"icon-name"}
    size={24}
    color={"white"}
    round
/>

Observarions

On Google Fonts, there is the Two Tone style. I choosed to not add it because I didn't notice any difference between the the Two Tone and Regular styles.

The glyphmaps for MaterialIcons changed. Each variant can have icons that doesn't exists in other variants. And each variant can have one icon that points to a different codepoint while have the same name. Therefore, each style has its codepoints object.

If there are anything to change, please let me know.

@brijeshc
Copy link

This will be a much-needed and awaited addition. Material Icons have been updated for a while. It will be great if this PR is merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants