Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font weight being overriden for variable fonts #1489

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matinzd
Copy link

@matinzd matinzd commented Feb 28, 2023

Font weights are being overridden when it's being passed from the component style properties.
I don't know if that's gonna break the current implementation of other font icons, but as far as I tested react native automatically applies normal fontWeight to the text if you don't pass it.

You can check font weights here with material symbols:
https://fonts.google.com/icons

Android: WIP

font weights are being overridden when it's being passed from the component style properties.
@matinzd matinzd changed the title fix: font weight being overriden fix: font weight being overriden for variable fonts Mar 1, 2023
@matinzd matinzd marked this pull request as draft March 1, 2023 07:42
@matinzd
Copy link
Author

matinzd commented Mar 1, 2023

I delved further into the issue and discovered prior open issues indicating inadequate support for it on Android. As a result, let's hold off on implementing it until I can attempt to address the problem on Android and evaluate its feasibility. I'm confident that you, @oblador, have already considered this, but please let me know if you have any suggestions or why it wasn't resolved on the Android side. As far as I'm aware, we may need to choose a separate file for each font weight on Android, but variable fonts should function properly without any workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant