Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FontAwesome 5 Pro Duotone style #1227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hampustagerud
Copy link
Collaborator

Adds support for FontAwesome 5 Duotone style, solves #1053 🙂 Probably not entirely ready to merge so awaiting feedback from other users

@oblador
Copy link
Owner

oblador commented Sep 10, 2020

Gotten any feedback yet? :D

@dan-lee
Copy link

dan-lee commented Oct 7, 2020

I think this would be a fantastic addition and I'd be happy to try it out, if you can tell me how?

@FRizzonelli
Copy link

@oblador Can we have this merged? It'd be awesome <3

@dan-lee
Copy link

dan-lee commented Mar 30, 2021

Still a sorrowly missing feature, can we give it a spin again?

@hampustagerud
Copy link
Collaborator Author

It's easy to ask for a feature but at some point someone got to do the work, I did it and asked for input but got no response. Instead I keep getting notifications where the feature is requested 🤷‍♂️

I asked for feedback in the linked issue and has still not received any but I realise that there is some more stuff to do related to the font explorer etc. However, my time is pretty limited these days and I can't work with this as part of my job anymore 🙂 If someone could help me test it more properly I will update the PR and make it ready though (if someone wants to help out with the actual work as well that is of course welcome 😉 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants