Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Office Fabric Icons #1038

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add Office Fabric Icons #1038

wants to merge 12 commits into from

Conversation

douglasjunior
Copy link

@douglasjunior douglasjunior commented Jul 5, 2019 •
edited

To enable the import, we have created a repository containing the CSS and TTF files, because Microsoft dont provide an easy way to get it (see README). Please feel free to suggest improvements in this process.

We also have created a Sample project for tests purpose:

Android iOS

Now we need to know what steps are missing:

  • Created the import script to generate glyphmaps, FabricIcons.js and copy the TTF.
  • Add to README
  • Add to the IconExplorer
  • Add to the directory

/cc @willianrod

@douglasjunior douglasjunior changed the title [WIP] Add Office Fabric Icons. Add Office Fabric Icons Jul 5, 2019
@catalinmiron
Copy link
Collaborator

Hey @douglasjunior,

Thanks for adding this icon font to the suite. Could you also update the directory + IconExplorer projects to have this icon font as well.

@douglasjunior
Copy link
Author

douglasjunior commented Sep 4, 2019 •
edited

Hi @catalinmiron , sorry for delay, and thanks for the feedback.

IconExplorer and Directory done!

IconExplorer

iOS Android
Screen Shot 2019-09-04 at 13 12 40 Screen Shot 2019-09-04 at 13 06 23

Directory

Screen Shot 2019-09-04 at 13 15 40

@douglasjunior
Copy link
Author

Guys, any other action is step to merge this PR?

@douglasjunior
Copy link
Author

Fixed conflicts in ./directory generated files.

@douglasjunior
Copy link
Author

@nazrdogan @catalinmiron any updates?

Tranks!

@douglasjunior
Copy link
Author

Fixed conflicts again.

@douglasjunior
Copy link
Author

Updated FabricIcons.js to the new export format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazrdogan nazrdogan nazrdogan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@douglasjunior @catalinmiron @nazrdogan @willianrod