Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LineAwesome #1019

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edeckers
Copy link

This PR adds the LineAwesome font to the package

@edeckers edeckers force-pushed the elydeckers/feature/add-line-awesome branch from bd2ba6a to 1a59664 Compare June 12, 2019 16:42
Copy link
Collaborator

@catalinmiron catalinmiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @hampustagerud could you please take a look as well?
Thanks!

@hampustagerud
Copy link
Collaborator

LGTM 🙂

@edeckers
Copy link
Author

This PR was approved 3 months ago, what are your plans on merging it?

@edeckers edeckers force-pushed the elydeckers/feature/add-line-awesome branch from 1a59664 to 559fe20 Compare July 18, 2020 10:26
@edeckers edeckers changed the title Add LineAwesome WIP Add LineAwesome Jul 18, 2020
@edeckers edeckers changed the title WIP Add LineAwesome Add LineAwesome Jul 18, 2020
@edeckers
Copy link
Author

edeckers commented Jul 18, 2020

@catalinmiron, @hampustagerud you approved this PR almost a year ago. Today I rebased it on the most recent master, any chance you can merge it?

@edeckers edeckers changed the title Add LineAwesome WIP Add LineAwesome Jul 18, 2020
@edeckers edeckers force-pushed the elydeckers/feature/add-line-awesome branch from 559fe20 to a8a4062 Compare July 18, 2020 17:34
@edeckers edeckers changed the title WIP Add LineAwesome \Add LineAwesome Jul 18, 2020
@edeckers edeckers changed the title \Add LineAwesome Add LineAwesome Jul 18, 2020
@edeckers edeckers force-pushed the elydeckers/feature/add-line-awesome branch 3 times, most recently from b1a4479 to 57e8fd0 Compare August 1, 2020 23:29
@edeckers
Copy link
Author

edeckers commented Aug 1, 2020

@oblador Tonight I rebased this branch on master. I hope you can share your thoughts about merging this PR? Anything I can do to help?

@egorshulga
Copy link

@oblador we really need this, LineAwesome icons look so great! Is there a chance this PR could be merged?

@edeckers edeckers force-pushed the elydeckers/feature/add-line-awesome branch from 57e8fd0 to 4e40ba3 Compare November 6, 2020 22:23
@edeckers
Copy link
Author

edeckers commented Nov 6, 2020

I just rebased this branch to make it easier to merge. If there is anything I can do to help, let me know!

@egorshulga
Copy link

@edeckers @hampustagerud we're still needing someone with write access. Is there a chance we could find someone? 😄

@egorshulga
Copy link

@catalinmiron @hampustagerud @oblador Hey guys! Is there anything we could do for this PR to be merged? 😭

@egorshulga
Copy link

@oblador @catalinmiron @hampustagerud sorry for being a little bit noisy, but we really want this PR.
Is there anyone who can help us with merging this PR?

@catalinmiron
Copy link
Collaborator

@egorshulga you can also integrate a custom icon font using this library. Please refer to https://github.com/oblador/react-native-vector-icons#custom-fonts also let me know if you need any help with it.

Adding LineAwesome will also increase the package/bundle size.

@egorshulga
Copy link

@catalinmiron Yeah, I tried, the main issue was that it is hard to include .ttf file into project (as far as I understand this would requrie some gradle scripting, but I am not sure). As this library provides its own framework of including fonts, it would be much easier just to include it into distribution package.

As far as I know, even with this library fonts are to be included manually, so the size of the package does not directly influence the size of the resulting app (it is still under developers control).

Anyway, I despaired to get line-awesome icons with this library, so I went into googling and found another library, which provides line-awesome icons for RN. It uses different approach (drawing via svg), but it worked, and as I was desperate to get line-awesome in my project (brain icon is so much better than in other libraries), so I went into this approach.

Still, I believe someday this PR would be dealt with (a year and a half of hanging in the nothingness!), so I would switch back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants