fix: unrecognized platform name visionOS #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
androideveloper
approved these changes
Mar 25, 2024
|
fyi @oblador new release is needed for this 🙏 |
|
@oblador is there anyone who can release this project other than you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624
Remove
@available(visionOS 1, *), which is only available on Xcode 15 and above. Use obj-c preprocessor directives instead.This was following the same approach as iOS in the lines below
@available(iOS 11, *). iOS needs this because FaceID is only available on iOS 11 and above. VisionOS does not need it because visionOS 1 already has OpticID since launch.Tested on Xcode 14.3.1 and 15.2.