[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

sohail-shrestha · 2022-12-22T10:26:18Z

Issue #571

The following lines of code were added to android's build.gradle.

  compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
  }

What this fixes:

Older react native projects not handling lambda functions.

Error Message:

 error: method references are not supported in -source 7
    final Thread warmingUp = new Thread(instance::internalWarmingBestCipher, "keychain-warming-up");
                                                  ^
  (use -source 8 or higher to enable method references)

varunkukade · 2023-06-02T13:49:51Z

@oblador Can you please merge this PR. Or else could you please suggest me what changes are not as per expectation. I will try to do those and create new PR.
Thanks.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-keychain](https://togithub.com/oblador/react-native-keychain) | [`^8.1.2` -> `^8.1.3`](https://renovatebot.com/diffs/npm/react-native-keychain/8.1.2/8.1.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-keychain/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-keychain/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-keychain/8.1.2/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-keychain/8.1.2/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-keychain (react-native-keychain)</summary> ### [`v8.1.3`](https://togithub.com/oblador/react-native-keychain/releases/tag/v8.1.3) [Compare Source](https://togithub.com/oblador/react-native-keychain/compare/v8.1.2...v8.1.3) #### What's Changed - use setUserAuthenticationParameters for android >= 11 by [@AntoineThibi](https://togithub.com/AntoineThibi) in [oblador/react-native-keychain#613 - \[Fix]\[Android] Bugfix for lambda functions not workin in older projects. by [@sohail-shrestha](https://togithub.com/sohail-shrestha) in [oblador/react-native-keychain#585 - \[Fix]\[Android] Unsupported RSA key size for StrongBox by [@frw](https://togithub.com/frw) in [oblador/react-native-keychain#577 #### New Contributors - [@AntoineThibi](https://togithub.com/AntoineThibi) made their first contribution in [oblador/react-native-keychain#613 - [@sohail-shrestha](https://togithub.com/sohail-shrestha) made their first contribution in [oblador/react-native-keychain#585 - [@frw](https://togithub.com/frw) made their first contribution in [oblador/react-native-keychain#577 **Full Changelog**: oblador/react-native-keychain@v8.1.2...v8.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

…inc#4947) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-keychain](https://togithub.com/oblador/react-native-keychain) | [`^8.1.2` -> `^8.1.3`](https://renovatebot.com/diffs/npm/react-native-keychain/8.1.2/8.1.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-keychain/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-keychain/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-keychain/8.1.2/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-keychain/8.1.2/8.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-keychain (react-native-keychain)</summary> ### [`v8.1.3`](https://togithub.com/oblador/react-native-keychain/releases/tag/v8.1.3) [Compare Source](https://togithub.com/oblador/react-native-keychain/compare/v8.1.2...v8.1.3) #### What's Changed - use setUserAuthenticationParameters for android >= 11 by [@AntoineThibi](https://togithub.com/AntoineThibi) in [oblador/react-native-keychain#613 - \[Fix]\[Android] Bugfix for lambda functions not workin in older projects. by [@sohail-shrestha](https://togithub.com/sohail-shrestha) in [oblador/react-native-keychain#585 - \[Fix]\[Android] Unsupported RSA key size for StrongBox by [@frw](https://togithub.com/frw) in [oblador/react-native-keychain#577 #### New Contributors - [@AntoineThibi](https://togithub.com/AntoineThibi) made their first contribution in [oblador/react-native-keychain#613 - [@sohail-shrestha](https://togithub.com/sohail-shrestha) made their first contribution in [oblador/react-native-keychain#585 - [@frw](https://togithub.com/frw) made their first contribution in [oblador/react-native-keychain#577 **Full Changelog**: oblador/react-native-keychain@v8.1.2...v8.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

sohail-shrestha changed the title ~~Bugfix for lambda functions not workin in older projects.~~ [Fix][Android] Bugfix for lambda functions not workin in older projects. Dec 22, 2022

varunkukade mentioned this pull request Jun 2, 2023

when I run my project, throw this error , how can solve this ? #597

Open

androideveloper force-pushed the bugfix/specify-java-version branch from 59f5dcd to 08f611e Compare February 15, 2024 10:45

Release 8.1.1

5416263

androideveloper force-pushed the bugfix/specify-java-version branch from 08f611e to 5416263 Compare February 15, 2024 10:46

androideveloper approved these changes Feb 15, 2024

View reviewed changes

androideveloper merged commit f5bef7e into oblador:master Feb 15, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

sohail-shrestha commented Dec 22, 2022 •

edited

varunkukade commented Jun 2, 2023

[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

Conversation

sohail-shrestha commented Dec 22, 2022 • edited

Issue #571

varunkukade commented Jun 2, 2023

sohail-shrestha commented Dec 22, 2022 •

edited