Allow to synchronize keychain items to iCloud #497
Conversation
| @@ -248,23 +256,28 @@ - (void)insertKeychainEntry:(NSDictionary *)attributes | |||
| } | |||
| } | |||
|
|
|||
| - (OSStatus)deletePasswordsForService:(NSString *)service | |||
| - (OSStatus)deletePasswordsForOptions:(NSDictionary *)options | |||
There was a problem hiding this comment.
Does it really make sense to have this as a part of the delete query?
There was a problem hiding this comment.
The options dictionary?
It would be consistence with the other methods..
The alternative in my opinion would be having the service and the flag as params
There was a problem hiding this comment.
I think Joel meant if we need the synchronized flag for the reset functions, because it doesn't really change behaviour - does it?
There was a problem hiding this comment.
From my understanding, with the sychronized flag the entry is deleted from the iCloud keychain, otherwise in the device keychain
|
this pr is still working? |
|
@m-ruhl hi, thanks for doing this. Quick question - does this Synchronized flag work for Android - to persist the entries in keychain beyond a single device? |
Going by the docs and changes made by @m-runl, its iOS only |
Closes #156