keychain/android: let client app access keychain from native code #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgenov
force-pushed
the
extract_keychain
branch
3 times, most recently
from
c2b8973
to
78b9e3f
Compare
rishabhyadavv
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
Great. This will resolve issue of fetching credential in native.
Example: I am using Share Intent for sharing image or files to other user. I require credentials for same but i can only get same if parent app is running since this require react native context.
|
Hi and thank you for the PR, unfortunately this is a little too big for a proper review and since we don't have any tests, I'm afraid this could break things. I'll try to get back to this but if you can think of a way to deliver this in a more review-friendly way, that would be nice. Thanks. |
mgenov
force-pushed
the
extract_keychain
branch
from
78b9e3f
to
0ba7584
Compare
This change extracts the Keychain related code into separate class which to be used by the client apps which would like to access it from the native side.
mgenov
force-pushed
the
extract_keychain
branch
from
0ba7584
to
02464e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts the Keychain related code into a separate class which to be used by the client apps which would like to access it from the native side.
Fixes #219