Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update java version in maven-compiler-plugin #73

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

advasileva
Copy link
Contributor

@advasileva advasileva commented Feb 25, 2023

Update Java version from 8 to 11. Closes #71


PR-Codex overview

This PR updates the project's compiler version from Java 8 to Java 11.

Detailed summary

  • Updated the source and target versions for the maven-compiler-plugin in pom.xml from 8 to 11.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #73 (1dbfac1) into master (f3eab25) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #73   +/-   ##
=========================================
  Coverage     73.52%   73.52%           
  Complexity       11       11           
=========================================
  Files             6        6           
  Lines            68       68           
  Branches          5        5           
=========================================
  Hits             50       50           
  Misses           18       18           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advasileva
Copy link
Contributor Author

@volodya-lombrozo I updated the java version to 11, but the project stopped being assembled due to the IllegalArgumentException of qulice -- https://github.com/objectionary/speco/actions/runs/4271509780/jobs/7436026079#step:11:4252. I don't really understand what the problem is, maybe you have encountered this error?

@volodya-lombrozo
Copy link
Member

volodya-lombrozo commented Feb 26, 2023

@advasileva Looks like it's a quite old problem.

@advasileva
Copy link
Contributor Author

@volodya-lombrozo This advice from Mikhail helped hide errors in the ide. Of course, it's better to fix the original problem with qulice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong java version in maven-compiler-plugin
3 participants