Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong java version in maven-compiler-plugin #71

Open
volodya-lombrozo opened this issue Feb 25, 2023 · 2 comments · May be fixed by #73
Open

Wrong java version in maven-compiler-plugin #71

volodya-lombrozo opened this issue Feb 25, 2023 · 2 comments · May be fixed by #73
Assignees
Labels
bug Something isn't working

Comments

@volodya-lombrozo
Copy link
Member

We expect that maven during compilation will use 8 version of Java:

      <plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.10.1</version>
        <configuration combine.self="override">
          <source>8</source>
          <target>8</target>
        </configuration>
      </plugin>

But at the same time we use features from Java 11:

Files.readString(path);
...
Path.of(...);

I don't clearly understand why maven even build the project, but in my IDEA a see tons of warning and errors. Can we increase the version of Java for maven-compiler-plugin, at least to make it more clear?

@volodya-lombrozo
Copy link
Member Author

@advasileva What do you think?

@advasileva advasileva linked a pull request Feb 25, 2023 that will close this issue
@advasileva
Copy link
Contributor

@volodya-lombrozo Answered in #73

@volodya-lombrozo volodya-lombrozo added the bug Something isn't working label Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants