Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more built-in dataization functions #291

Merged
merged 43 commits into from May 13, 2024
Merged

Add more built-in dataization functions #291

merged 43 commits into from May 13, 2024

Conversation

aabounegm
Copy link
Collaborator

@aabounegm aabounegm commented Apr 17, 2024


PR-Codex overview

This PR updates the eo-phi-normalizer project by adding support for binary and bytestring dependencies, improving dataization results, and enhancing dependency merging logic.

Detailed summary

  • Added support for binary and bytestring dependencies
  • Improved dataization results in multiple files
  • Enhanced dependency merging logic in Language.EO.Phi.Dependencies
  • Updated functions for converting between different data types

The following files were skipped due to too many changes: eo-phi-normalizer/app/Main.hs, site/docs/src/normalizer/transform.md, eo-phi-normalizer/test/eo/phi/dataization.yaml, eo-phi-normalizer/src/Language/EO/Phi/Dataize.hs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@aabounegm aabounegm marked this pull request as ready for review April 24, 2024 11:11
@aabounegm aabounegm marked this pull request as draft May 3, 2024 14:29
@aabounegm aabounegm marked this pull request as ready for review May 3, 2024 20:19
@fizruk
Copy link
Collaborator

fizruk commented May 6, 2024

Please, add missing tests for the implemented atoms.

@deemp
Copy link
Member

deemp commented May 7, 2024

@aabounegm, it's currently not clear what version of EO you use as a reference implementation of atoms.

Please specify in this issue the commit in the objectionary/eo repo.

Alternatively, you can write that you look atoms in the eo submodule so that you don't need to specify a commit URL.

@aabounegm
Copy link
Collaborator Author

aabounegm commented May 8, 2024

@deemp It's because I wasn't previously using EO as a reference 😅, I was just looking at their usages in the eo-phi-normalizer/data/0.37.0 directory and depending on my understanding of the atom name. I will review the original implementation in the eo repo and verify that my understanding was correct, since I now know where they are implemented.

For reference, they are implemented in eo-runtime/src/main/java/EOorg/EOeolang.

Update: it seems what I implemented so far matches my understanding of the Java code.

@fizruk fizruk merged commit 2bacfaf into master May 13, 2024
@fizruk fizruk deleted the builtin-functions branch May 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants