Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] Extended pattern matching #258

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[proposal] Extended pattern matching #258

wants to merge 4 commits into from

Conversation

deemp
Copy link
Member

@deemp deemp commented Apr 5, 2024 •
edited by pr-codex bot

Related to #65 (comment)

Support matching more patterns in PHI expressions.

PR-Codex overview

This PR introduces extended pattern matching syntax to find and extract specific objects deep within a program.

Detailed summary

  • Introduces extended pattern matching syntax for deep object extraction
  • Provides Syntax v0 and Syntax v1 examples
  • Includes a grammar definition for Syntax v1
  • Offers examples and explanations for understanding the syntax and usage

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@deemp deemp mentioned this pull request Apr 16, 2024
Open
@deemp deemp mentioned this pull request Apr 24, 2024
Closed
@deemp deemp mentioned this pull request May 7, 2024
Closed
2 tasks
@deemp deemp added the proposal under review Proposal that is being reviewed by the normalizer team label May 7, 2024
@deemp
Copy link
Member Author

deemp commented May 13, 2024

@maxonfjvipon, please review

maxonfjvipon
maxonfjvipon reviewed May 13, 2024
View reviewed changes
proposals/001-extended-pattern-matching.md Outdated
value: "hello"
- metavar: "?Bindings"
value: [and ↦ you]
- metavar: "?PathHead"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deemp where did ?PathHead come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From nowhere. Removed in 9f3cd7d

@deemp deemp requested a review from yegor256 May 17, 2024 12:21
@deemp deemp mentioned this pull request May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon left review comments

@yegor256 yegor256 Awaiting requested review from yegor256

Assignees
No one assigned
Labels
proposal under review Proposal that is being reviewed by the normalizer team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deemp @maxonfjvipon