Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qulice to 0.22.2 #2997

Merged
merged 9 commits into from Mar 28, 2024
Merged

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Mar 25, 2024

Closes #2937


PR-Codex overview

This PR updates method names, adds assertion messages, improves exception handling, and enhances dependencies in various Maven plugin test files.

Detailed summary

  • Renamed key() method to getKey()
  • Added assertion messages in multiple test files
  • Improved exception handling with @SuppressWarnings("PMD.CognitiveComplexity")
  • Enhanced dependencies by updating versions

The following files were skipped due to too many changes: eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChRemoteTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChTextTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/hash/ChPattern.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyRemoteTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/util/FileHashTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/MarkMojoTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/Moja.java, eo-maven-plugin/src/test/java/org/eolang/maven/tojos/ForeignTojosTest.java, eo-parser/src/test/java/org/eolang/parser/ObjectsTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/rust/NamesTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/VerifyMojo.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyHomeTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/CopyMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/RegisterMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyFilesystemTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/dependencies/DcsEachWithoutTransitiveTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java, eo-maven-plugin/src/main/java/org/eolang/maven/OptimizationTask.java, eo-maven-plugin/src/main/java/org/eolang/maven/OptimizeMojo.java, eo-parser/src/main/java/org/eolang/parser/XePhiListener.java, eo-maven-plugin/src/main/java/org/eolang/maven/tojos/TranspiledTojos.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/ObjectsIndexTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/ParseMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/footprint/FtDefaultTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/tojos/PlacedTojos.java, eo-maven-plugin/src/main/java/org/eolang/maven/UnplaceMojo.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyIndexedTest.java, eo-parser/src/test/java/org/eolang/parser/ParsingTrainTest.java, eo-parser/src/test/java/org/eolang/parser/EoIndentLexerTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/PullMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/BinarizeMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyFallbackSwapTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/tojos/TranspiledTojosTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/footprint/FtCachedTest.java, eo-parser/src/test/java/org/eolang/parser/StUnhexTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyFallbackTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/tojos/PlacedTojo.java, eo-maven-plugin/src/main/java/org/eolang/maven/SafeMojo.java, eo-maven-plugin/src/test/java/org/eolang/maven/SodgMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/util/HmBaseTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/UnplaceMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/BinarizeParseTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/OptimizeMojoTest.java, eo-parser/src/test/java/org/eolang/parser/EoSyntaxTest.java, eo-parser/src/main/java/org/eolang/parser/XeEoListener.java, eo-maven-plugin/src/test/java/org/eolang/maven/ResolveMojoTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/tojos/ForeignTojos.java, eo-maven-plugin/src/test/java/org/eolang/maven/TranspileMojoTest.java, eo-maven-plugin/src/test/java/org/eolang/maven/PlaceMojoTest.java, eo-maven-plugin/src/main/java/org/eolang/maven/tojos/ForeignTojo.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Mar 25, 2024

@maxonfjvipon could you check this one, please?

@yegor256
Copy link
Member

yegor256 commented Mar 28, 2024

@maxonfjvipon let's merge this one before it expires?

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Mar 28, 2024

@yegor256 @c71n93 let's merge master to it first and restart CI

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Mar 28, 2024

@yegor256 or, since there's no conflicts, let's try to merge

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 28, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 82b5710 into objectionary:master Mar 28, 2024
16 checks passed
@rultor
Copy link
Contributor

rultor commented Mar 28, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 20min)

c71n93 added a commit to c71n93/eo that referenced this pull request Apr 19, 2024
@c71n93 c71n93 deleted the 2937-update-qulice branch May 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade qulice to 0.22.2
4 participants