Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade qulice to 0.22.2 #2937

Closed
yegor256 opened this issue Mar 13, 2024 · 4 comments · Fixed by #2997
Closed

upgrade qulice to 0.22.2 #2937

yegor256 opened this issue Mar 13, 2024 · 4 comments · Fixed by #2997
Labels

Comments

@yegor256
Copy link
Member

Let's upgrade it to 0.22.2: there are many fixes to be made, but they are not hard to make.

@yegor256 yegor256 added the bug label Mar 13, 2024
@yegor256
Copy link
Member Author

@c71n93 maybe you can help?

@c71n93
Copy link
Member

c71n93 commented Mar 14, 2024

@yegor256 Ok, I will take it

@c71n93
Copy link
Member

c71n93 commented Mar 14, 2024

@yegor256 There are A LOT OF warnings, that says: "JUnit assertions should include a message". The problem is, that in most of tests we don't have assertion messages. It is impossible to write an informative message to every assertion in an adequate amount of time. I see 2 options here:

  1. Suppress this warnings in all test methods (maybe add todo).
  2. Add stub messages like "" or "Message".

@yegor256 WDYT?

@yegor256
Copy link
Member Author

@c71n93 it's better to add meaningful messages, as much as possible

c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
c71n93 added a commit to c71n93/eo that referenced this issue Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants