Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

second part of store tests conversion to kotlin #357

Open
wants to merge 2 commits into
base: feature/kotlin_conversion
Choose a base branch
from
Open

second part of store tests conversion to kotlin #357

wants to merge 2 commits into from

Conversation

brianPlummer
Copy link
Contributor

No description provided.

@brianPlummer brianPlummer added this to the 4.0 milestone Jul 18, 2018
@brianPlummer
Copy link
Contributor Author

@pavlospt @digitalbuddha

@brianPlummer brianPlummer requested a review from tiwiz July 18, 2018 21:22
wdziemia
wdziemia approved these changes Jul 25, 2018
View reviewed changes
store/src/test/java/com/nytimes/android/external/store3/GetRefreshingTest.kt
class GetRefreshingTest {
@Mock
internal lateinit var persister: ClearingPersister
internal lateinit var networkCalls: AtomicInteger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be private?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tiwiz tiwiz tiwiz approved these changes

@wdziemia wdziemia wdziemia approved these changes

@candidcold candidcold candidcold approved these changes

@ramonaharrison ramonaharrison ramonaharrison approved these changes

@cybo42 cybo42 Awaiting requested review from cybo42

@goldstei goldstei Awaiting requested review from goldstei

Assignees
No one assigned
Labels
Kotlin Type: Enhancement Type: Quality Matters
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brianPlummer @tiwiz @wdziemia @candidcold @ramonaharrison