Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Local Asset Sync #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattclements
Copy link

Similar to REMOTE_DB_USING_SSH, offer the ability to locally sync assets such as when staging/live is on the same environment (i.e. without requiring SSH) via a new flag REMOTE_ASSETS_USING_SSH

@khalwat
Copy link
Contributor

khalwat commented Sep 18, 2018

So this already works if staging and live are on the same server; the server just ssh's into itself.

The reason I kept it this way is to keep the code path pure/simple. I'll have a look at the PR tho.

@mattclements
Copy link
Author

Thanks @khalwat - the issue is that a user needs to then copy their Public Key (for the web server user) into the same users authorized_keys to let this work. The pull request removes the requirement for this, which allows the scripts to be more easily adopted en-mass

@terryupton
Copy link

This is very useful for my setup @khalwat - is this something you are likely to merge?

@khalwat
Copy link
Contributor

khalwat commented Oct 29, 2018

I want to have a good review of it, but I'm not opposed to the idea, as long as it isn't adding an additional code path (which it doesn't appear to be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants