Introduce Biome for lint instead of TSLint #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
This PR introduces Biome instead of TSLint. I enabled only lint feature. I skip formatter and analyzer here.
This PR was created because of its superiority over ESLint in terms of speed, readiness to install formatter features.
ESLint and typescript-eslint have the advantage of being de facto with abundant rules. If ESLint is needed, I will close this PR and create a PR that uses that one.
Referencing previous tslint.json, TSLint rule triple-equals is enabled by default in Biome as noDoubleEquals.
Others are set false, so ignored (it means, there is no need to suppress Biome's lint rules if the lint command passes).
Caring about disabled TSLint rules in comments (I deleted):
max-line-lengthis responsibility of the formatter in Biome.no-shadowed-variableis not implemented in Biome, but discussed here.NOTICE
Currently, Biome cannot handle lint rules that require TypeScript type info. For example, no-floating-promise. The team would like to address this, but has not found a definitive solution.
So, in this TSLint's recommended set, biome can't handle the lint rules require type info.