feat: align output of searchcount component with neovim default #1202
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested every case locally (
|
camoz
force-pushed
the
patch-2
branch
2 times, most recently
from
64289a9
to
268ab4b
Compare
shadmansaleh
reviewed
Mar 9, 2024
| if result.current <= result.maxcount then | ||
| return string.format('[%d/>%d]', result.current, result.maxcount) | ||
| else | ||
| return string.format('[>%d/>%d]', result.maxcount, result.maxcount) |
There was a problem hiding this comment.
what do we have in result.current in this case?
Neovim's default formatting for indicating the search result position, from `:h search-commands`:
[1/5] Cursor is on first of 5 matches.
[1/>99] Cursor is on first of more than 99 matches.
[>99/>99] Cursor is after 99 match of more than 99 matches.
[?/??] Unknown how many matches exists, generating the
statistics was aborted because of search timeout.
Meaning of result.incomplete, from `:h searchcount()`:
0: search was fully completed
1: recomputing was timed out
2: max count exceeded
|
Been using this for nearly 2 months now without any issues... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neovim's default formatting for indicating the search result position, from
:h search-commands:Meaning of result.incomplete, from
:h searchcount():