Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add a space after status_symbol #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nerosnm
Copy link

@nerosnm nerosnm commented Mar 2, 2021

I noticed once I'd set this up that when I only had hints, no space was being added after the status symbol:

Hint With No Space

I expected to find when I looked in the code that this was unintentional, but this looks pretty intentional. However, I think this should be considered a bug, because it treats hints differently from the other types of diagnostics.

This change makes the diagnostics when there are only hints...

Hint With Space

...render the same as when there are other types of diagnostics too, e.g. hints and errors:

Screenshot 2021-03-02 at 11 35 06

@wbthomason wbthomason linked an issue Mar 3, 2021 that may be closed by this pull request
@wbthomason
Copy link
Collaborator

Thanks! As mentioned in #35 (which this will close), this was because the statusline proof-of-concept code came from my own setup, which uses a double-wide symbol for hints and looks wrong with a space added.

I'm happy to merge this and make handling of the different diagnostics types more consistent, but perhaps we should also change the default symbol (

indicator_hint = '',
) in this PR, to ensure that things still look correct with the defaults?

@nerosnm
Copy link
Author

nerosnm commented Mar 3, 2021

Ah okay, I understand. So we'd need to change the default indicator_hint so that it has a space before it?

@wbthomason
Copy link
Collaborator

That's one option, I suppose. I more meant that we'd just change the default indicator_hint symbol to one that isn't double-wide and therefore will look OK with the space added after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: reasoning behind only_hint
2 participants