Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): correct path with custom nitro.output.dir #376

Merged
merged 1 commit into from
May 30, 2024

Conversation

xjccc
Copy link
Contributor

@xjccc xjccc commented Mar 27, 2024

#375

delete nitro.srcDir

@pi0 pi0 changed the title fix: preview path fix(preview): correct path with custom nitro.output.dir Mar 27, 2024
@pi0
Copy link
Member

pi0 commented Mar 27, 2024

Thanks. Have to locally doublecheck but this seems a nice fix.

(for context, addition was from nuxt/nuxt#18882)

@xjccc
Copy link
Contributor Author

xjccc commented Mar 27, 2024

Thanks. Have to locally doublecheck but this seems a nice fix.

(for context, addition was from nuxt/nuxt#18882)

Thanks for quick reply. I run the cli in my local. And set config with playground, find this simple way to resolve path. I don't know is something change build by nitro?

And i also have a question, when i set ~/node-server the path can't resolve correct. But it's a special scene for this, it's need to solve?

@danielroe danielroe requested a review from pi0 May 28, 2024 12:09
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR and sorry for delay on merging it

@pi0 pi0 merged commit 03d4a54 into nuxt:main May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants