New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add notes with scoop x64 #670
base: master
Are you sure you want to change the base?
Conversation
x64 support json
Hey, thanks for working on this! :) I haven't tested this properly yet, as I don't usually review draft pull requests, because they're technically not ready... But anyway, you should probably update the |
I'm not familiar with how Scoop works, but after we install Notes using it, how do we open it? I assume Notes can only be launched through the command line, and it won't be available in Windows' start menu... Or am I mistaken? |
Hi, thanks
okay
I was wondering if you'd like to try it first, the scoop isn't very complicated.
PS: Test on another machine or on a virtual machine before your personal machine.
There is a way to auto-update, but I still don't understand how it works or how to do it correctly with scoop.
Once you download the file and unzip it, it will look like a command line. I didn't make a complete script that creates a shortcut effectively.
yes. exactly, command line.
I didn't make a complete script that creates a shortcut effectively.
you are sure. And that's why I open a draft here. I was wondering where I should store notes.json, or if I should create notesx86.json, notesx64.json or something more complete. Or how this script should work. If I get more information, this pull request goes from being a draft to something more complete. |
Thanks for clarifying things! In my opinion, since Notes is obviously a graphical-only program, having a shortcut in the start menu to open it is a must. If this is indeed doable with Scoop, I'd prefer having that before we could merge it.
I'm not sure what other contributors think, but in my opinion, having a single We pretty much only offer the x86 Qt 5 build because, apparently, some of our users are still on Windows 7, where Qt 6 isn't officially supported. |
thanks for info.
For this other reason, I open a draft pull request. So I'll wait for new information from other contributors, I'd rather send something that everyone agrees on
yes.
I was asking if I should submit the pull request to the scoop community or here |
I definitely think it would make more sense to submit to the Scoop community instead. Based on a quick look I took at how Scoop works, they seem to have their own official repositories, so installing Notes from one of those would be much better, IMO. However, if they have a way to "import" the Scoop file from third-party repositories (i.e., from here into their own repositories), I think it would be even better. Just so we can "control" the release process better, directly from here. |
true.
yes.
it is possible.
yeah. |
Hey there!
I'll leave a simple example here of a file called: "notes.json" that is responsible for installing and unzipping the nuttyartist/notes file[v2.2.1/Notes_2.2.1-Qt5.15.2-x64-Windows-Portable.zip]. This is my pull request to support the installation of notes on x64 through scoop the manifest .json file stored in this repository. This example can be found here:
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests