Merge pull request #4665 from Meet2rohit99/Issue4353

Add Prefix in TestContext.AddTestAttachment for long file paths
nunit · Mar 19, 2024 · 2f9d052 · 2f9d052
2 parents 95cd3b3 + 11d612d
commit 2f9d052
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/NUnitFramework/framework/TestContext.cs b/src/NUnitFramework/framework/TestContext.cs
@@ -369,7 +369,13 @@ public static void AddTestAttachment(string filePath, string? description = null
             if (!Path.IsPathRooted(filePath))
                 filePath = Path.Combine(TestContext.CurrentContext.WorkDirectory, filePath);
 
-            if (!File.Exists(filePath))
+            string prefix = string.Empty;
+#if NETFRAMEWORK
+            if (Environment.OSVersion.Platform == PlatformID.Win32NT & filePath.Length > 260)
+                prefix = @"\\?\";
+#endif
+
+            if (!File.Exists($"{prefix}{filePath}"))
                 throw new FileNotFoundException("Test attachment file path could not be found.", filePath);
 
             var result = TestExecutionContext.CurrentContext.CurrentResult;

diff --git a/src/NUnitFramework/tests/TestContextTests.cs b/src/NUnitFramework/tests/TestContextTests.cs
@@ -29,7 +29,7 @@ public class TestContextTests
         [OneTimeSetUp]
         public void CreateTempFile()
         {
-            _tempFilePath = Path.Combine(TestContext.CurrentContext.WorkDirectory, TempFileName);
+            _tempFilePath = Path.Combine(_workDirectory, TempFileName);
             File.Create(_tempFilePath).Dispose();
         }
 
@@ -386,6 +386,29 @@ public void NoneExistentFileThrowsFileNotFoundException()
             Assert.That(() => TestContext.AddTestAttachment("NotAFile.txt"), Throws.InstanceOf<FileNotFoundException>());
         }
 
+        [TestCase(IncludePlatform = "Net")]
+        public void LogFilePathDoesNotThrow()
+        {
+            string longPathPrefix = string.Empty;
+
+            if (Environment.OSVersion.Platform == PlatformID.Win32NT)
+                longPathPrefix = $@"\\?\";
+
+            /* Absolute file path length greater than 260 are considered long paths for .NET Framework
+             * Creating 261 length file path */
+            string tempLongFilePath = Path.Combine(_workDirectory, new string('A', (260 - _workDirectory.Length) - 4) + ".tmp");
+            try
+            {
+                File.Create($"{longPathPrefix}{tempLongFilePath}").Dispose();
+
+                Assert.That(() => TestContext.AddTestAttachment(tempLongFilePath), Throws.Nothing);
+            }
+            finally
+            {
+                File.Delete($"{longPathPrefix}{tempLongFilePath}");
+            }
+        }
+
         #endregion
 
         #region Retry